Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying task config via environment and CLI #400

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

bennybp
Copy link
Collaborator

@bennybp bennybp commented Apr 4, 2023

Description

This allows for setting the task config (number of nodes, memory, etc) via the CLI and by environment variables.

(I am looking to run more via the CLI than the python interface, for various reasons.)

Changelog description

Task configuration can now be set via CLI and environment variables

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #400 (493a852) into master (d18cfda) will increase coverage by 0.03%.
The diff coverage is 96.77%.

Additional details and impacted files

Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and tests good to me, thanks! evading the parse_environment is a little troubling, but the tests involving $envvar still work, so ok.

@loriab loriab merged commit e5a43ba into master Aug 7, 2023
13 checks passed
@loriab loriab deleted the more_task_config branch August 7, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants