fix hanging file warning

MolSSI · Sep 23, 2024 · 10a264d · 10a264d
1 parent f488e72
commit 10a264d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/qcengine/programs/nwchem/runner.py b/qcengine/programs/nwchem/runner.py
@@ -105,9 +105,8 @@ def get_version(self) -> str:
                     if "nwchem branch" in line:
                         branch = line.strip().split()[-1]
                     if "nwchem revision" in line:
-                        revision = "+" + line.strip().split()[-1]
-                revision = "" if (revision == "+N/A") else revision
-                self.version_cache[which_prog] = safe_version(branch + revision)
+                        revision = line.strip().split()[-1]
+                self.version_cache[which_prog] = safe_version(branch + "+" + revision)
             else:
                 raise UnknownError(output["stderr"])
 

diff --git a/qcengine/util.py b/qcengine/util.py
@@ -339,6 +339,8 @@ def read_from_buffer(buffer: BinaryIO, storage: io.BytesIO, sysio: TextIO):
             # Retrieve the standard output for the process
             ret["stdout"] = stdout.getvalue().decode()
             ret["stderr"] = stderr.getvalue().decode()
+            ret["proc"].stdout.close()
+            ret["proc"].stderr.close()
 
 
 @contextmanager