Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate finding of include paths in CMake for each dependency library. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

multiplemonomials
Copy link

This fixes the error I was getting:

CMake Error in mirp/CMakeLists.txt:
  Imported target "mirp_imported_mpfr" includes non-existent path
    "/usr/lib/include"
  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:
  * The path was deleted, renamed, or moved to another location.
  * An install or uninstall procedure did not complete successfully.
  * The installation package was faulty and references files it does not
  provide.

It's caused by the build system assuming that all headers are at location ../include relative to their respective library, which isn't always true.

I also bumped the version number to 1.0.2 so that dependers can ask for the updated version.

Also bumped version number to 1.0.2 so that dependers can ask for the updated version.
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@ca4d36c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   86.88%           
=========================================
  Files             ?       23           
  Lines             ?     1525           
  Branches          ?        0           
=========================================
  Hits              ?     1325           
  Misses            ?      200           
  Partials          ?        0           

@multiplemonomials
Copy link
Author

@bennybp any way you could take a look at this? We are using MIRP on the QUICK project and this is causing us some issues integrating it.

@bennybp
Copy link
Collaborator

bennybp commented Mar 26, 2021

I think this looks reasonable. I see you also changed the version. Will you need a new tag/release?

I can add the tag, but probably can't do the full (compiled) releases like I did a few years ago.

@multiplemonomials
Copy link
Author

It's up to you I guess. Having a source release should be fine though.

@multiplemonomials
Copy link
Author

@bennybp Were you ever going to make that release?

@multiplemonomials
Copy link
Author

@bennybp bump^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants