Updates for MDI library based on static code analysis with Coverity Scan #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akohlmey Thanks very much for these fixes! Sorry for the slow response - I've been out of the office for a while. The changes look good to me. I've run the CI tests, and everything looks good. The Windows test is failing for reasons unrelated to these changes. I'll take care of issue #158, and then let you know when I've released a new patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling static code analysis in LAMMPS for the MDI package with Coverity Scan (https://scan.coverity.com/) also several issues were reported for the MDI library.
This pull request tries to address them. Most are peripheral and have only a minor impact, but the change in commit 78bc193 is a real bugfix.
Please also check out issue #158