Split general contractions into blocks whenever possible #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the BSE split general contractions into blocks whenever possible.
For example, if the contraction pattern looks like
this will be identified by the code, and the general contraction will be split into two shells, consisting of the
x
andy
entries, respectively.A special case of the procedure concerns completely free primitives
which will from now on not be included in the generally contracted shell; instead, they will be contained in their own shells.
The PR doesn't have any functional changes, since the output formats will still act exactly the same: formats that employ general contractions will show the blocked contractions, whereas formats employing segmented contractions are already omitting any zero entries.
The main reason for the PR is to improve curation tools: identical basis sets are now detected as identical, since the placing of e.g. free primitives as a dummy part of the contraction pattern vs as one-function shells does not affect how the BSE treats the functions internally. The new convention may also slightly reduce storage costs, since zero entries don't need to be stored.