Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use built-in types #262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use built-in types #262

wants to merge 1 commit into from

Conversation

thomaschhh
Copy link
Member

What does this PR do?

This PR uses built-in types instead of using the ones from the typing module.
It also implements the adherence to PEP 604.

General Changes

  • ..

Breaking Changes

  • ..

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)
  • I have updated the internal changelog (CHANGELOG_DEV.md)

@thomaschhh thomaschhh linked an issue Sep 24, 2024 that may be closed by this pull request
Annotations: Adhere to PEP 604 / Leverage Built-In 3.10 Functionality #260
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le1nux le1nux Awaiting requested review from le1nux

@mali-git mali-git Awaiting requested review from mali-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations: Adhere to PEP 604 / Leverage Built-In 3.10 Functionality
1 participant
@thomaschhh