Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #816
Summary:
feedFeatureFlag
(TODO: clean up everywhere else)Got to 79 performance on localhost, in QA / PROD this should improve due to javascript bundling
Further improvements to the Feed Detail page would be a lot of effort. Areas that could improve
BroadcastChannel
prevents the page from being cachedI don't think it's worth exploring these at this time
Biggest improvement and things to note going forward
The biggest issue on the Feed Detail Page is that as the page loads, there were many moving elements which makes for a bad user experience. Bad user experience = performance because performance is what users perceive not always speed. This measure is known as Cumulative Layout Shift (CLS) and we were getting really bad scores in it.
With the addition of the skeleton loading and waiting for the dataset data, the page became much more stable in terms of content display
Expected behavior:
When going to the feed detail page (gtfs or gtfs_rt) there should be a skeleton loading elements before the real content shows up. Also when the content shows up, it should all be there (no bounding box coming late)
Testing tips:
Play around with the feed detail pages, go from page to page, refresh, go back etc
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anythingBefore changes (localhost)
After changes (localhost)
Skeleton Loading (feed detail page)
General Loader (to iterate on)