Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monthly update] October 2024 #545

Merged
merged 13 commits into from
Oct 29, 2024
Merged

[Monthly update] October 2024 #545

merged 13 commits into from
Oct 29, 2024

Conversation

Sergiodero
Copy link
Contributor

This PR updates the following files in EN, ES and FR to align with the latest changes in the google/transit repo:

  • Schedule Reference
  • Realtime reference
  • Realtime Feed Entities - Trip Modifications
  • Realtime Protobuf page
  • Realtime Protobuf file
  • Realtime Revision History

Changes consist of:

I've tested the changes locally and formatting looks good.

@skalexch do you mind reviewing the English files?
@eliasmbd could you please have a look at the French translation?

Thanks!

Copy link

@skalexch skalexch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sergiodero the realtime aspect looks good. Only missing the change I made in google/transit#510. Should change "blank" to "empty" in en/documentation/schedule/reference.md. Otherwise it's all good on the en side, consistent with the changes.

@Sergiodero
Copy link
Contributor Author

Sergiodero commented Oct 29, 2024

Thanks @skalexch that was addressed in b8b2c6a, can you confirm that the changes are reflected? I do see it as "Empty" on my end.

Also, if you have some time could you have a look at the FR version of the changes?

@Sergiodero
Copy link
Contributor Author

Thanks @skalexch the latest commit addressed the issues with the french version discussed in person, I'm merging now.

@Sergiodero Sergiodero merged commit 5bf394f into main Oct 29, 2024
@Sergiodero Sergiodero deleted the monthly-update-october2024 branch October 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants