Definition Improvement of Trip Durations_NEW #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "travel" durations (rider-oriented) by "trip" durations (vehicle/service-oriented)
For mean_duration: - Better definition of the "mean" and "safe" concepts - Define when the trip durations start and end
For safe_duration - Better definition of the "safe" concept - Define when the trip durations start and end - Replace "SafeTravelDuration" by "SafeTripDuration"
|
|
|
lgtm! |
|
This looks like an improvement but I think that we should remove "based on historical data" from both definitions. I can see basing these factors/offsets on historical data as a best practice, but historical data won't always be available (e.g., new service, but also due to lack of data for existing services), so we shouldn't imply that it is required. |
|
Removed "based on historical data" |
|
@tzujenchanmbd Are you going to transfer this over to google/transit before we close this repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
PR#48 was created by @timMillet 2 years ago, and there seemed to be a consensus on the changes. However, the discussion stopped and the changes have not been merged yet. Since the old branch is 45 commits behind the current master(current flex proposal), I am creating this new PR to include [all previous proposed changes + typo revision + a tiny change based on a suggestion from comment] to the current proposal.
(side note: this PR doesn't include what we discussed on issue#73, plan to create another PR for that)
Changes in this PR include:
-Quote from PR#48
-New changes
For previous discussion, please see PR#48.
@timMillet @westontrillium @tsherlockcraig could you please have another look at this PR? If this looks ok we can merge to current proposal.