-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spark 4.0 support #297
Draft
dolfinus
wants to merge
1
commit into
develop
Choose a base branch
from
feature/test-spark4.0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #297 +/- ##
===========================================
+ Coverage 91.94% 91.97% +0.02%
===========================================
Files 225 225
Lines 9649 9684 +35
Branches 987 998 +11
===========================================
+ Hits 8872 8907 +35
+ Misses 588 586 -2
- Partials 189 191 +2 ☔ View full report in Codecov by Sentry. |
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 18:52
0e55abd
to
b91db4e
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:02
b91db4e
to
3d1d944
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:08
3d1d944
to
469c1d9
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:20
469c1d9
to
dd21d0a
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:26
dd21d0a
to
776f351
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:32
776f351
to
0ef84bd
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 12:28
0ef84bd
to
d0c9090
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 12:47
d0c9090
to
1a00a33
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 12:52
1a00a33
to
dca6397
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 13:00
dca6397
to
d050a2d
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 13:45
d050a2d
to
849659e
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 13:53
849659e
to
978dc31
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 14:06
978dc31
to
e68423d
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 14:11
e68423d
to
ffaba47
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 3, 2024 13:50
c7d76ba
to
d97b236
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 3, 2024 13:58
d97b236
to
fe8208d
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 11:00
fe8208d
to
2b46cbd
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 11:11
2b46cbd
to
0290394
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 11:31
0290394
to
2f08db1
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 11:45
2f08db1
to
3406360
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 11:52
3406360
to
bf03e79
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 13:12
bf03e79
to
7bb1aac
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 13:54
7bb1aac
to
a236028
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 14:06
a236028
to
d20d9e7
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 4, 2024 15:24
d20d9e7
to
068fe01
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 5, 2024 12:02
068fe01
to
da0ae6b
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 5, 2024 12:09
da0ae6b
to
f5ee6f8
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
December 5, 2024 12:17
f5ee6f8
to
f23637a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
get_packages()
andcheck_if_supported()
methods, as Spark 4.0 includes XML support.DecimalType(38, 10).typeName()
started returningdecimal(38, 10)
instead ofdecimal
, which breaks some Oracle tests. UpdatedSparkTypeToHWM
implementation to have direct mapping between Spark data type classes and HWM classes.Notes:
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)