Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode log data to ascii string using c string pointer #217

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Encode log data to ascii string using c string pointer #217

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49247af
Encode log data to ascii string using c string pointer
memoto Oct 17, 2024
897ac22
Merge branch 'MobileNativeFoundation:master' into master
memoto Dec 16, 2024
987ee78
Fix linting
memoto Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sources/XCLogParser/loglocation/LogLoader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,17 @@
do {
let data = try Data(contentsOf: url)
let unzipped = try data.gunzipped()
guard let contents = String(data: unzipped, encoding: .ascii) else {
let string: String? = unzipped.withUnsafeBytes { pointer in
guard let charPointer = pointer
.assumingMemoryBound(to: CChar.self)
.baseAddress

Check failure on line 32 in Sources/XCLogParser/loglocation/LogLoader.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
memoto marked this conversation as resolved.
Show resolved Hide resolved
else {
return nil
}

return String(cString: charPointer, encoding: .ascii)
}
guard let contents = string else {
throw LogError.readingFile(url.path)
}
return contents
Expand Down
Loading