-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kover to 0.9.0-RC, Add Coverage Report to CI, and Consolidate Workflows #673
Conversation
Signed-off-by: matt-ramotar <[email protected]>
Signed-off-by: matt-ramotar <[email protected]>
You're on an old version of Kover, and they made some improvements, including better detection of certain constants patterns that don't need coverage. Recommend updating to latest stable (or check out rc build), as well as looking into any central exclusions that would make sense for the project wide. |
.github/workflows/codecov.yml
Outdated
- uses: codecov/codecov-action@v4 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
files: ./kover/coverage.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the coverage file being treated as generated code in PR review process already? If not, that should be added to the .gitattributes file so it doesn't create additional noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout, thanks. We were previously checking it in. Removed coverage reports from the repo, updated our .gitignore, and modified our workflows accordingly.
Signed-off-by: matt-ramotar <[email protected]>
Signed-off-by: matt-ramotar <[email protected]>
Signed-off-by: matt-ramotar <[email protected]>
Signed-off-by: matt-ramotar <[email protected]>
… fetch all history and tags Signed-off-by: matt-ramotar <[email protected]>
Signed-off-by: matt-ramotar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 67.23% 75.32% +8.08%
==========================================
Files 39 38 -1
Lines 934 920 -14
Branches 194 169 -25
==========================================
+ Hits 628 693 +65
+ Misses 205 142 -63
+ Partials 101 85 -16
|
…Workflows (#673) * Run codecov on PR and push Signed-off-by: matt-ramotar <[email protected]> * Use codecov-action@v4 with CODECOV_TOKEN Signed-off-by: matt-ramotar <[email protected]> * Remove coverage files Signed-off-by: matt-ramotar <[email protected]> * Update .gitignore Signed-off-by: matt-ramotar <[email protected]> * Update kover to 0.9.0-RC Signed-off-by: matt-ramotar <[email protected]> * Consolidate workflows Signed-off-by: matt-ramotar <[email protected]> * Update workflow to check out the repository on the correct branch and fetch all history and tags Signed-off-by: matt-ramotar <[email protected]> * Format Signed-off-by: matt-ramotar <[email protected]> --------- Signed-off-by: matt-ramotar <[email protected]>
This PR is:
My goal is to get our coverage above 90%. Will start chipping away at uncovered code after this merges.