Set Outputs via DeviceID #1950
Merged
Set Outputs via DeviceID #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for this pull request: |
DocMoebiuz
reviewed
Feb 24, 2025
Co-authored-by: Sebastian M <[email protected]>
DocMoebiuz
approved these changes
Feb 24, 2025
|
Build for this pull request: |
|
Build for this pull request: |
DocMoebiuz
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from @DocMoebiuz branch 1885, so it's not my work. An additional bugfix to show up PWM pins in the UI is added. For this the pin number also for version 3 has to be saved in the class.
PR is issued to get a compiled version of the connector for users which need to use FW version 3.0.0 (like A6/A7 for ProMicro, ...)
Changes:
Outputs will be set via the deviceID and not via the pin anymore. This harmonize how to address all devices. The required changes are already part of the FW release 3.0.0.
If the board has a FW version of 3.0.0 or higher, the setting of outputs gets overriden by a new class. The new class sends the deviceID instead of the pin number
Fixes #1885