Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MIDI devices show in connected devices dropdown #1945

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Feb 9, 2025

Fixes #1944

There were two issues:

  • The event handler for MIDI device lookup finishing was getting set after MIDI device manager was starting. This was a race condition, and on my computer the MIDI lookup was finishing before the event handler was added so it was never called.
  • The code to actually add the menu items was adding things to the joystick menu instead of the MIDI menu.

The race condition could also happen for Joysticks so I did a minor refactor to create specific start methods to kick off the Joystick and MIDI managers, and only call them after the event handlers are added.

image

@neilenns neilenns requested a review from DocMoebiuz as a code owner February 9, 2025 21:47
Copy link

github-actions bot commented Feb 9, 2025

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz DocMoebiuz merged commit df21412 into MobiFlight:main Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIDI devices don't show in the connected devices status bar menu
2 participants