better peer close error messages #136
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
crypto/blake2b_test.go#L58
Error return value of `x.Read` is not checked (errcheck)
|
|
lint:
common/encoding.go#L314
Error return value of `enc.WriteByte` is not checked (errcheck)
|
|
lint:
common/encoding.go#L329
Error return value of `enc.WriteByte` is not checked (errcheck)
|
|
lint:
common/encoding.go#L341
Error return value of `enc.WriteByte` is not checked (errcheck)
|
|
lint:
p2p/handle.go#L528
Error return value of `peer.syncRing.Offer` is not checked (errcheck)
|
|
lint:
p2p/peer.go#L200
Error return value of `me.sendHighToPeer` is not checked (errcheck)
|
|
lint:
p2p/sync.go#L102
Error return value of `me.SendSnapshotFinalizationMessage` is not checked (errcheck)
|
|
lint:
kernel/boot.go#L17
Error return value of `node.loopCacheQueue` is not checked (errcheck)
|
|
lint:
kernel/cosi.go#L94
Error return value of `chain.node.Peer.SendTransactionRequestMessage` is not checked (errcheck)
|
|
lint:
kernel/cosi.go#L413
Error return value of `chain.AppendCosiAction` is not checked (errcheck)
|
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint:
util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
|
|
lint:
config/reader.go#L14
var-naming: const KernelNetworkId should be KernelNetworkID (revive)
|
|
lint:
crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
|
|
lint:
crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
|
|
lint:
crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
|
|
lint:
common/validation.go#L335
increment-decrement: should replace signers += 1 with signers++ (revive)
|
|
lint:
common/decoding.go#L125
increment-decrement: should replace il -= 1 with il-- (revive)
|
|
lint:
common/encoding.go#L207
increment-decrement: should replace off += 1 with off++ (revive)
|