Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actions and docker images #622

Merged
merged 1 commit into from
Feb 25, 2024
Merged

update actions and docker images #622

merged 1 commit into from
Feb 25, 2024

Conversation

Migelo
Copy link
Contributor

@Migelo Migelo commented Feb 25, 2024

The only non-trivial change is updating actions/upload-artifact from v2 to v4, source. They don't allow for artifacts with the same name being uploaded and overwriting each other. This happened in the linux-ci workflow where different gcc versions were used but the artifact they produced had the same name, making the v4 action fail. I fixed it by creating a unique name for each gcc version.

    -  name: et-client-${{matrix.os}}
    +  name: et-client-${{matrix.os}}-gcc${{matrix.gcc}}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (9af9f16) to head (5dbf9c3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   73.02%   73.19%   +0.16%     
==========================================
  Files          50       49       -1     
  Lines        3051     3096      +45     
==========================================
+ Hits         2228     2266      +38     
- Misses        823      830       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MisterTea
Copy link
Owner

Thanks!

@MisterTea MisterTea merged commit 39cc495 into MisterTea:master Feb 25, 2024
26 checks passed
@Migelo Migelo deleted the feature/update branch February 25, 2024 15:57
@Migelo
Copy link
Contributor Author

Migelo commented Feb 25, 2024

Great! Would you be interested in adding renovatebot to the repo? I used it to get these updates done. With the configuration below the bot creates an issue that acts as the dashboard and then makes pull requests when it detects a new version of something. If tests pass it will then merge minor version bumps with major version bumps requiring a manual merge.

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:base"
  ],
  "includeForks": true,
  "lockFileMaintenance": {
    "enabled": true,
    "automerge": true,
    "automergeType": "pr",
    "platformAutomerge": true
  },
  "platformAutomerge": true,
  "packageRules": [
    {
      "description": "Automerge non-major updates",
      "matchUpdateTypes": ["minor", "patch"],
      "enabled": true,
      "automerge": true,
      "automergeType": "pr",
      "platformAutomerge": true
    },
    {
      "matchDepTypes": ["devDependencies"],
      "matchPackagePatterns": ["lint", "prettier"],
      "enabled": true,
      "automerge": true,
      "automergeType": "pr",
      "platformAutomerge": true
    }
  ]
}

@MisterTea
Copy link
Owner

Sounds interesting! Please submit a PR so I can review

@Migelo Migelo mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants