Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders for SAN loss localization #1587

Merged

Conversation

lozanoje
Copy link
Contributor

Description.

Added placeholders localization for SAN loss on NPC sheet

Types of Changes.

To NPC template, and to en.json to add two more keys

Placeholders for pass/fail
Placeholders por pass/fail
@pconcepcion
Copy link
Contributor

Sorry for the confusion @lozanoje, I understood this was an Issue and created my own MR, I'll cacel it, but please fix this one to include also the placeholders of the else branch and the spanish localization file.

@lozanoje
Copy link
Contributor Author

I've fixed the error in the placeholder and also I've updated the es.json file from the CoC7 translation module since its been a long time from the last time I sent the updated file to the system.

@snap01 snap01 merged commit 2dc1f10 into Miskatonic-Investigative-Society:develop Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants