Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased KCP Fragments #35

Closed
wants to merge 10 commits into from
Closed

Increased KCP Fragments #35

wants to merge 10 commits into from

Conversation

JesusLuvsYooh
Copy link

Credits to the top-men / advisors and the big guy himself.

We do get people trying to send large mb maps, or 4k HD camera footage (in Update() ) in hashtag help, so its for those rare few, + future proofing.

Credits to the top-men / advisors and the big guy himself.

We do get people trying to send 200mb maps, or 4k HD camera footage (in Update() )  in hashtag help, so its for those rare few, + future proofing.
vis2k and others added 4 commits November 30, 2021 11:03
@miwarnec
Copy link
Collaborator

looks good, just need one 70 MB send test to be sure.
needs different window sizes in test settings tho, I can add it later

@miwarnec
Copy link
Collaborator

miwarnec commented Dec 1, 2021

for future reference.
70mb sending did not seem to work atm.
worth considering keeping the old limit possibly

@JesusLuvsYooh
Copy link
Author

Old limit was 288 kb right?
I can get 10,000 kb to work with the above changes, before unity, kcp or my hardware disagrees with it.
Its a massive difference, even if we cant reach the 70,000 kb we'd hoped.

I'l ask in the Discord for opinions.

@miwarnec
Copy link
Collaborator

miwarnec commented Jan 7, 2022

not merged yet, sorry.
considering NetworkReader/Writer fixed capacity pooling.
where we would always pool max sized readers/writers.
in which case the 144 KB max is quite nice.
int.max nice would not be so ni ce

@miwarnec miwarnec force-pushed the master branch 2 times, most recently from e65e85b to 6baf722 Compare January 9, 2022 04:14
@JesusLuvsYooh JesusLuvsYooh closed this by deleting the head repository Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants