Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose file version to latest (3.6) #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

epcim
Copy link
Contributor

@epcim epcim commented Apr 27, 2018

In order to support latest docker-compose syntax, set latest possible version.
PR updates syntax files to 3.6 (later updated somehwre between 3.2 - 3.6)

Update:
as proved during CI, travis environment don't support yet prereqsites:

  • docker-compose >= v1.20.x
  • docker engine >= v18.02

follow-up updates will lower minor version to latest possible.

@katyafervent
Copy link
Contributor

I have same issue on my local machine, by default docker-compose has
docker-compose -v
docker-compose version 1.8.0, build unknown

and with 1.20.0 everything is OK

@epcim
Copy link
Contributor Author

epcim commented Apr 27, 2018

yes, doc says


Compose file format | Docker Engine release
-- | --
3.6 | 18.02.0+
3.5 | 17.12.0+

@naumvd95
Copy link
Contributor

@epcim pls write commit body properly, why we need it? and have u checked tests? its already failed
IMO we can't change depend-software versions without important reason, coz there are a lot of dependencies and also need to check backport compatibility

Copy link
Contributor

@naumvd95 naumvd95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epcim pls write commit body properly, why we need it? and have u checked tests? its already failed
IMO we can't change depend-software versions without important reason, coz there are a lot of dependencies and also need to check backport compatibility

- set docker-compose file version to latest supported by CI (3.5)
@epcim epcim force-pushed the compose-version-36 branch from cdfd2bc to 242d7b1 Compare April 29, 2018 06:45
@naumvd95
Copy link
Contributor

@epcim

In order to support latest docker-compose syntax,


what syntax do u want to define?

@naumvd95
Copy link
Contributor

naumvd95 commented May 3, 2018

i mean , what feature do u want to get, whats the main goal of bumping?

@naumvd95 naumvd95 added the backlog delayed fixes/features label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog delayed fixes/features discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants