-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Login by social providers (Google for now) #1326
base: master
Are you sure you want to change the base?
[FEAT] Login by social providers (Google for now) #1326
Conversation
Damn, this is awesome! |
Hey @timothycarambat, are there any intentions to work on this PR? It looks really good |
@emilioh93 There is nothing wrong with the PR, it just needs to be reviewed and we need documentation to set it up because I dont want to be responsible for 400 github issues from people setting it up incorrectly and saying it is broken! From what i already tested, it works great & will be merged |
@timothycarambat, thanks for your reply. I agree that documentation is crucial to avoid configuration issues. I appreciate your time and effort in reviewing this PR. |
What are the places where should one put the documentation? |
@matejc Our docs repo https://github.com/Mintplex-Labs/anythingllm-docs |
Oh I am excited about this feature, thanks! |
It's great! It simply opens the path for other login methods such as LDAP. Ideal for self hosted in a small company. |
this would be a fantastic feature! Waiting for this to get merged. |
@timothycarambat I have a need for this as well, and i have taken these changes and rebuild them on the current version of anythingLLM. I will work up the docs in a PR as well. My changes will probably cause this to be closed instead. it just looked like this had fallen stale with other updates to anythingLLM. i am doing final rounds of testing on the changes locally this week. |
additionally, @timothycarambat would you be OK if i added proper Saml SSO support in an additional PR separately? turns out, id rather have that than this, but I have already coded this login with google part. sorta figure they could coexist |
This is a game changer - is there a reason this hasn't received much tlc? Understand LDAP/SAML are prevalent in established IT envs, but Google/OAuth is much more practical in small setups. |
Ive been testing my changes in our dev environment a bit, but should be
looking to open the PR to merge in the next week or so.
β¦On Sat, Dec 14, 2024 at 5:59β―PM Scott de Jong ***@***.***> wrote:
This is a game changer - is there a reason this hasn't received much tlc?
Understand LDAP/SAML are prevalent in established IT envs, but Google/OAuth
is much more practical in small setups.
β
Reply to this email directly, view it on GitHub
<#1326 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEUKJPKRNZKCMYIM2FLDML2FSZ65AVCNFSM6AAAAABHPUWSXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGM3DQOBRGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Thanks for helping push this feature towards the finish line! Besides a domain restriction, is there a way to limit which users can log in with this method? If not, would a CAS or SAML integration be required? |
GOAT |
well, im not as far on the saml route. and honestly, there were some new
login features just released this last week that will mostly likely require
some rebasing on my part etc.
I have been focused on carrying forward the awesome work of Giovanni B just
within the newer version of settings UI etc that came out after he pushed
his changes originally.
β¦On Sun, Dec 15, 2024 at 11:00β―AM Giovanni Borgogno ***@***.***> wrote:
Ive been testing my changes in our dev environment a bit, but should be
looking to open the PR to merge in the next week or so.
GOAT
β
Reply to this email directly, view it on GitHub
<#1326 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEUKJMTQCJUX3CL3DH5BNL2FWRSZAVCNFSM6AAAAABHPUWSXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHEZDQMZTGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Pull Request Type
Relevant Issues
resolves #1193
What is in this change?
This PR introduces the ability for users to log in using their Google accounts, providing the flexibility for administrators to enable or disable this feature. Additionally, administrators can restrict login access to a specific organization's domain. The implementation is designed with a modular structure, allowing for easy integration of additional authentication providers in the future.
Additional Information
After enable login by google:
Developer Validations
yarn lint
from the root of the repo & committed changes