Incorporate Trackless Pions #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamesserly
force-pushed
the
mehreen_michels
branch
2 times, most recently
from
d49e39e to
104415f
Compare
bamesserly
force-pushed
the
mehreen_michels
branch
from
104415f to
d70a305
Compare
bamesserly
force-pushed
the
mehreen_michels
branch
from
fe7685e to
2a98bf3
Compare
bamesserly
force-pushed
the
mehreen_michels
branch
2 times, most recently
from
bc3966d to
72bd8e7
Compare
bamesserly
force-pushed
the
mehreen_michels
branch
from
72bd8e7 to
66b2b6b
Compare
Also: add Ever's new michel tuple location to ccpion_common. And: reformat my Michel.h.
all the variables that Mehreen plots.
Remove some of it from Cuts. Mehreen's vertex michels need Cluster.
They probably overlap with some of my functions or some standard functions. Should consolidate them.
I don't think we'll need to save it to CVU, but maybe.
Add Mehreen's CVU and update format her hascut file.
Cleared out Cuts.* files. Moved unused cuts to RetiredCuts, which probably doesn't compile, but can be used for reference or to easily revive old cuts. Moved most helper functions to CutUtils, which is compiled and doesn't have many dependencies. Lastly, attempting to use the new PassesCuts function which returns all returns by value, not by reference.
1. update some branch names for newer version of mehreen branches. 2. had accidentally removed iso prongs cut. 3. replace raw branch read in signal def with official mnrva function.
Cluster, Michel, and Cuts all compile now. Only CCPiEvent needs to be reviewed before all compiles. In the end I only tweaked the cutting strategy for vertex michels: still do all the exclusive cuts kLLR, etc as usual, but now first fill a separate vertex michels container, which the exclusive cuts don't affect. Then only, liek the multipi cut changed. Big restructure of Michel and cuts code. Don't modify michel containers by ref any more - only return them directly. Break out MichelEvent to be a mere data container class. Switch vectors of Michels in there to be vectors of pointers to Michels, to dodge circular dependency. Save the trackless michels to the CVU in order to calculate pion quantities from them. Otherwise a good vertex michel is coded as a pion candidate track of index -1. Big todos: 1) match michels (using clusters) between vertex and endpoint so we don't double count. 2) argument or option to turn off vertex michel analysis. Otherwise, next is fix CCPiEvent and implement test loop in studies/runNewMichel.C
bamesserly
force-pushed
the
mehreen_michels
branch
from
f200483 to
750d865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weave in Mehreen's work on untracked pions that are detected with a michel only.