Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for CrystallographyCore to 0.6, (keep existing compat) #124

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CrystallographyCore package from 0.4.2, 0.5 to 0.4.2, 0.5, 0.6.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@singularitti singularitti force-pushed the compathelper/new_version/2023-10-18-03-03-48-109-01000188136 branch from 264ad1a to 55f7db6 Compare October 18, 2023 03:03
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d466d47) 56.13% compared to head (15816df) 58.43%.

❗ Current head 15816df differs from pull request most recent head 55f7db6. Consider uploading reports for the commit 55f7db6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   56.13%   58.43%   +2.29%     
==========================================
  Files          14       11       -3     
  Lines         269      255      -14     
==========================================
- Hits          151      149       -2     
+ Misses        118      106      -12     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@singularitti singularitti merged commit 7d6eaca into main Oct 18, 2023
12 of 37 checks passed
@singularitti singularitti deleted the compathelper/new_version/2023-10-18-03-03-48-109-01000188136 branch October 18, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant