Skip to content

Move EventCharacteristic to the internal package #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Move EventCharacteristic to the internal package #81

merged 1 commit into from
May 2, 2025

Conversation

Jonathing
Copy link
Member

Name entails. See the linked issue for details.

@Jonathing Jonathing requested a review from PaintNinja April 24, 2025 16:16
@Jonathing Jonathing self-assigned this Apr 24, 2025
PaintNinja
PaintNinja approved these changes Apr 26, 2025
View reviewed changes
Copy link
Contributor

@PaintNinja PaintNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we both overlooked that it was actually package-private, just in a publicly exported package. I'll approve and let you decide whether moving it or using it for being linked to in javadocs would be better.

@Jonathing
Copy link
Member Author

Package-private classes are not processed in the JavaDocs.

@PaintNinja PaintNinja merged commit f6a6e9b into MinecraftForge:master May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaintNinja PaintNinja PaintNinja approved these changes

Assignees

@Jonathing Jonathing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventCharacteristic interface should be moved to internal
2 participants
@Jonathing @PaintNinja