Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.x] correct the spelling of one word within events.md #503

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

srcres258
Copy link
Contributor

The word "busses" is invalid since the plural form of "bus" is only "buses", "busses" should be the third-person singular of "bus" but not the plural form of it. Consequently correct the mistake.

Within the 1.19.x version the issue above has been tackled, but the one within the 1.20.x version has not been modified yet. Hence carry out the fix as well for the latter.

The word "busses" is invalid since the plural form of "bus" is only
"buses", "busses" should be the third-person singular of "bus" but not the
plural form of it. Consequently correct the mistake.

Within the 1.19.x version the issue above has been tackled, but the one
within the 1.20.x version has not been modified yet. Hence carry out the
fix as well for the latter.

Signed-off-by: src_resources <[email protected]>
@srcres258 srcres258 changed the title 1.20.x: correct the spelling of one word within events.md [1.20.x] correct the spelling of one word within events.md Jul 15, 2023
Copy link
Member

@Jonathing Jonathing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a remedial PR, but I don't see why this shouldn't be pulled in for the time being.

@srcres258
Copy link
Contributor Author

srcres258 commented Jul 15, 2023

It's a remedial PR, but I don't see why this shouldn't be pulled in for the time being.

The same modification was merged yesterday within #502 for version 1.19.x, and this version is for 1.20.x.
If you are able to conduct the change by yourself for 1.20.x and reluctant to merge my change, feel free to close this PR and directly merge the change from the 1.19.x branch of this repository.

@Jonathing
Copy link
Member

I have no pull perms, I am simply marking this PR as ready as a triager.

@srcres258
Copy link
Contributor Author

I have no pull perms, I am simply marking this PR as ready as a triager.

Sorry for my misunderstanding.

@LexManos LexManos merged commit b3944ad into MinecraftForge:1.20.x Jul 15, 2023
@srcres258 srcres258 deleted the 1.20.x-fix-0 branch July 15, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants