CORE: Allow implicitly casting from a smaller integer to a bigger float

core/checker/checker.go

@@ -149,7 +149,7 @@ func (c *checker) expectPrimitiveValue(expr ast.Expr, kind ast.PrimitiveKind) {
 }
 
 func (c *checker) checkRequired(required ast.Type, expr ast.Expr) {
-	if required == nil || expr == nil || expr.Result().Kind == ast.InvalidResultKind {
+	if required == nil || expr == nil || expr.Result().Kind == ast.InvalidResultKind || expr.Result().Type == nil {
 		return
 	}
 

core/common/casts.go

@@ -111,9 +111,8 @@ func GetImplicitCast(from, to ast.Type) (CastKind, bool) {
 				return Extend, true
 			}
 
-			// Primitive (same integer) -> Primitive (same floating)
-			// TODO: Allow converting a smaller integer to the next bigger floating (eg. i16 -> f32)
-			if ast.IsInteger(from.Kind) && ast.IsFloating(to.Kind) && toSize == fromSize {
+			// Primitive (smaller or equal integer) -> Primitive (bigger or equal floating)
+			if ast.IsInteger(from.Kind) && ast.IsFloating(to.Kind) && toSize >= fromSize {
 				return Int2Float, true
 			}
 		}

core/llvm/instructions.go

@@ -124,7 +124,7 @@ func (w *textWriter) writeInstruction(inst ir.Inst) {
 		w.writeValueValue(inst.Right)
 
 	case *ir.AndInst:
-		w.writeString("add ")
+		w.writeString("and ")
 		w.writeValue(inst.Left)
 		w.writeString(", ")
 		w.writeValueValue(inst.Right)

gen/ast.go

@@ -161,6 +161,10 @@ var expressions = Group{
 			"Paren",
 			field("expr", type_("Expr")),
 		),
+		node(
+			"Literal",
+			field("token", type_("scanner.Token")),
+		),
 		node(
 			"Unary",
 			field("prefix", type_("bool")),
@@ -235,10 +239,6 @@ var expressions = Group{
 			"Identifier",
 			field("name", type_("scanner.Token")),
 		),
-		node(
-			"Literal",
-			field("token", type_("scanner.Token")),
-		),
 	},
 }
 

tests/src/implicit_casts.fb

@@ -27,6 +27,14 @@ func int2float() bool {
     return b == 5f;
 }
 
+#[Test]
+func int2float_differentSize() bool {
+    var a u8 = 6 as u8;
+    var b f64 = a;
+
+    return b == 6.0;
+}
+
 #[Test]
 func long2double() bool {
     var a i64 = 5;

vscode/src/extension.ts

@@ -9,7 +9,7 @@ import {
 } from "vscode-languageclient/node";
 import {ChildProcess, exec} from "child_process";
 
-const DEV = true;
+const DEV = false;
 
 let process: ChildProcess;
 let client: LanguageClient;