Resolved #13. Fixed the crash if no target attributes in the xcode project.

[eddy-lau]

No description provided.

[p4checo]

Hi @eddy-lau 👋

Thanks for opening up #13 and this PR! 🙏
I'm curious, In what scenario(s) is the TargetAttributes dictionary nil?

Cheers! 🍻

[eddy-lau]

In my case, the 'TargetAttributes' of the xcode project generated by the ionic framework is nil.

[p4checo]

I see. That makes sense since we never had that issue with Xcode generated project files.

Even though we can fix the issue on the plugin, I think that the problem is caused by Ionic not properly generating the project file, don't you agree? Given this, perhaps you should also create an issue/file a bug on ionic framework 🐛😉

Additionally, have you tried opening up the project on Xcode after having generated it with Ionic (and before running cosigner), to see if the problem persists? (to test if Xcode fills in the missing information)

Cheers 🍻

[eddy-lau]

Xcode can open the freshly created project without any problem, and Xcode doesn't fill up the missing information. (I tested with Xcode 9 only).
I created an example project for reference.

[p4checo]

Thanks for testing that! It really is weird that Xcode doesn't fill the information up 🤔.
Have you also tried running the target via Xcode?

Anyway, I think we can merge this change, since it simply makes the plugins safer 😉
Just one note though, this plugin's functionality has been merged into fastlane, and is now available via the automatic_code_signing plugin.

Cheers!

[p4checo]

looks nice 👍
just please remove the version bump since we do that separately 😉

[p4checo]

we typically do this on a separate commit, so please remove 😉