ALFMOB-89: Error screen header not fixed to the top #30
+160
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The divider in the toolbar was not fixed to the top. To resolve this, we now use `frame` and `alignment` to anchor it at the top. However, this also causes views that should be centered within the remaining space to align at the top. To address this, some error views required a `Spacer` at the top and bottom. As part of this fix, a generic `ErrorView was created for use in all error scenarios.
JoaoPinhoMinder
requested review from
p4checo,
DanielPrimoMinder and
reisdev
p4checo
approved these changes
Feb 24, 2025
reisdev
approved these changes
Mar 11, 2025
JoaoPinhoMinder
deleted the
bug/ALFMOB-89-error-screen-header-not-fixed-to-the-top
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://mindera.atlassian.net/browse/ALFMOB-89
Description
The divider in the toolbar was not fixed to the top. To resolve this, we now use
frameandalignmentto anchor it at the top. However, this also causes views that should be centered within the remaining space to align at the top. To address this, some error views required aSpacerat the top and bottom. As part of this fix, a generic `ErrorView was created for use in all error scenarios.Evidences