Deps: bump up dune to 3.18.2 #17138
Open
Deps: bump up dune to 3.18.2 #17138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-toolchain-me |
This is an intermediary update to js_of_ocaml.5.8.2 and alcotest 1.8.0
Not existing anymore in Fmt.
glyh
reviewed
May 4, 2025
| @@ -449,15 +450,15 @@ let test_arg = | |||
|
|
|||
| let mina_image_arg = | |||
| let doc = "Identifier of the Mina docker image to test." in | |||
| let env = Arg.env_var "MINA_IMAGE" ~doc in | |||
| let env = Cmd.Env.info "MINA_IMAGE" ~doc in | |||
dannywillems
force-pushed
the
dw/bump-up-deps
branch
from
6e1ff0d to
93e88ea
Compare
|
!ci-toolchain-me |
|
!ci-build-me |
|
This is a big leap, did you check previously that all dependencies actual support dune 3.18? I think in particular js-of-ocaml has some restriction on dune |
|
!ci-bypass-changelog |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reviewer can reproduce it with:
The output of the first command must upgrade ONLY dune.