Skip to content

Dependency: Remove deprecated ocaml-migrate-parsetree #17137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

glyh
Copy link
Member

@glyh glyh commented May 4, 2025

This package is marked as deprecated, and it's not used at all. We should remove it.

@glyh glyh changed the base branch from develop to compatible May 4, 2025 07:11
@glyh
Copy link
Member Author

glyh commented May 4, 2025

!ci-build-me

@glyh glyh changed the title Remove deprecated package ocaml-migrate-parsetree Dependency: Remove deprecated ocaml-migrate-parsetree May 4, 2025
@glyh
Copy link
Member Author

glyh commented May 4, 2025

!ci-toolchain-me

@glyh glyh marked this pull request as ready for review May 4, 2025 07:53
@glyh glyh requested review from a team as code owners May 4, 2025 07:53
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the toolchain please?

@glyh
Copy link
Member Author

glyh commented May 4, 2025

!ci-toolchain-me

@glyh
Copy link
Member Author

glyh commented May 4, 2025

@dannywillems do you mind provide an example commit how this is done?

EDIT: d0a0f5b (#17138)

@glyh glyh requested a review from a team as a code owner May 4, 2025 12:44
@glyh
Copy link
Member Author

glyh commented May 4, 2025

!ci-build-me

@dannywillems
Copy link
Member

!ci-bypass-changelog

@glyh
Copy link
Member Author

glyh commented May 6, 2025

archive unit test is constantly failing. Need check before merge.

@glyh
Copy link
Member Author

glyh commented May 21, 2025

This need to be redo. But before that I'm keen on finding a way we could automate the CI toolchain me calls. @dannywillems

@glyh glyh closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants