-
Notifications
You must be signed in to change notification settings - Fork 574
Dependency: Remove async_ssl
#17136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compatible
Are you sure you want to change the base?
Dependency: Remove async_ssl
#17136
Conversation
!ci-build-me |
!ci-toolchain-me |
!ci-bypass-changelog |
I'm very surprised it is unused. I'm initially worried that it is used indirectly. But I'll have a deeper look later. |
I guess the related complexity goes into go's libp2p stuff? Unsure |
!ci-nightly-me |
!ci-build-me |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it is used by Cohttp_async, used in our GraphQL client.
This is weird as OPAM didn't resolve this as a dependency. Is it an optional dependency? |
These failing message is not very helpful
|
This is solved by restarting the job. |
Not really https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/37703#0196a19f-5f9a-41fc-b318-3356581c2866 These jobs have been restarted a couple of times. |
Although jobs should fail indeed. The error message makes no sense to me. |
async_ssl
is not used at all(not even transitive dependency it seems), so we should be able to remove it.Moreover, this package has compilation issue and it's one of the blocker for non-nix setup on Arch Linux.
EDIT:
To test this is indeed true:
In a mina's repo root:
The later command should give you a list of all actual dependency needed. BTW, We can see that
duration
is not tracked by theopam.export
file.Actually I'm trying this on
4.14.2
and patched the export file to use4.14.2
as well as I can't build4.14.0
on Arch Linux.