Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify versions between bindings and proof-systems + add asm flags #16091

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Sep 19, 2024

  • Unified packages/version lower bounds with proof-systems
    • As a result, Cargo.toml uses more same-version dependencies. serde_with is now 3.6.0 (which it was in proof-systems) only, and 2.3.3 is not used anymore. Same or serde_with_macros. rmp-serde is 1.1.2 now, and the 0.15.5 version is not used anymore.
  • Added asm flag to ark-ff

See:

@volhovm volhovm requested a review from a team as a code owner September 19, 2024 12:50
@volhovm volhovm force-pushed the volhovm/add-asm-flag-to-bindings branch from cced8b6 to c605f6b Compare September 19, 2024 12:51
@volhovm
Copy link
Member Author

volhovm commented Sep 19, 2024

!ci-build-me

@dannywillems
Copy link
Member

If you want to enforce a version to be exactly "x.y.z", you have to use "=x.y.z": https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

@volhovm
Copy link
Member Author

volhovm commented Sep 19, 2024

@dannywillems yeah I know, I admit that trying to have the lower bounds in Cargo files synchronized is a tiny bit pointless because cargo can still select different sets of (higher) versions for two builds (which it does). Unless bindings and proof-systems are in the same repo this is a bit pointless. But on the other side having toml declarations synced means the only difference can happen in lockfiles, which simplifies debugging I guess :)

(I was avoiding =x.y.z on purpose, leaving it upper-bound-open should decrease the probability of an ugly version conflict IIUC)

@volhovm
Copy link
Member Author

volhovm commented Sep 19, 2024

@dannywillems thanks! merging

@volhovm volhovm merged commit e863d7b into compatible Sep 19, 2024
46 checks passed
@volhovm volhovm deleted the volhovm/add-asm-flag-to-bindings branch September 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants