Skip to content

wasm-bindgen-rayon: change from submodule to cargo git dep #11287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2022
Merged

wasm-bindgen-rayon: change from submodule to cargo git dep #11287

merged 1 commit into from
Jun 16, 2022

Conversation

yorickvP
Copy link
Collaborator

  • Change wasm-bindgen-rayon from a git submodule to a cargo git dep. Tracks the branch at o1-labs/wasm-bindgen-rayon/feature/nodejs-support. Update using cargo generate-lockfile or cargo update.

This dep is an excellent candidate for this because it's very infrequently updated.

cc @mrmr1993

Part of #11212

@yorickvP yorickvP added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 15, 2022
@yorickvP yorickvP merged commit 9bf0f7d into develop Jun 16, 2022
@yorickvP yorickvP deleted the yorickvp/rm-cargo-submodules branch June 16, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@mitschabaude mitschabaude mitschabaude approved these changes

@bkase bkase Awaiting requested review from bkase

@psteckler psteckler Awaiting requested review from psteckler

@imeckler imeckler Awaiting requested review from imeckler

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yorickvP @mrmr1993 @mitschabaude