PM-2039 Support custom nodepool #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmarcou
force-pushed
the
pm-2039
branch
3 times, most recently
from
ae8dd70 to
fd6a086
Compare
kaozenn
reviewed
Nov 5, 2024
piotr-iohk
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
K8S_NODE_POOLenvironment variable to allow to spin pods on a specific node pool.This change be tested on staging cluster using the existing nodepool
mina-delegation-verify.This change will not need any update of the helm chart. The specific nodepool can be created in the gitops repository for the need of the deployment (given a cluster), and the environment variable can be set in mean time. I will open the PR for production when we are ready.