Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reference implementation #5

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Update reference implementation #5

merged 9 commits into from
Mar 20, 2024

Conversation

kantp
Copy link
Collaborator

@kantp kantp commented Mar 20, 2024

This PR does a couple of things:

  • Update the implementation to make use of TokenContract, to allow approving an arbitrary AccountUpdateForest.
  • Changes the Transferable and Approvable interfaces to match what TokenContract provides.
  • Remove a couple of interfaces that we decided were increasing the scope of the standard a bit too much, to keep it simple.
  • Remove the bun build tool, as it's apparently not working on every platform.

kantp added 9 commits March 20, 2024 18:27
@kantp
Revert to using npm instead of bun.
7dbf29e 
Apparently, bun does not support windows.
@kantp
Update to use TokenContract.
b2bd5de 
This allows approving arbitrary `AccountUpdate` forests.
@kantp
Add a test transferring tokens between two contracts.
8cc58f3
@kantp
Remove ViewableOptions
749caa2
@kantp
Simplify Transferable to match TokenContract
3558728
@kantp
Adapt Approvable to match TokenContract
f9362a7
@kantp
Some cleanup
e7be4d8 
Mainly respecting deprecation messages.
@kantp
Remove Pausable.
7877c3e 
It's nice, but not really necessary for the standard. Also, it wasn't actually
stopping transfers in the current implementation.
@kantp
Remove Hookable
a5bb8c4 
It's flexible, but makes the standard more complex than it needs to be.
@kantp kantp force-pushed the kantp/token-contract branch from 2c03e1e to a5bb8c4 Compare March 20, 2024 17:30
@kantp kantp merged commit 6d5d73d into develop Mar 20, 2024
0 of 2 checks passed
@harrysolovay harrysolovay deleted the kantp/token-contract branch March 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kantp