Basic token support in /search/transactions #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
requested review from
harrysolovay,
joaosreis and
johnmarcou
as code owners
joaosreis
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into some ordering issue in zkapp transaction response that turned into implementing basic token support (as it is in Rosetta, i.e. without token_symbols). I did that as it was easier to compare the repsponse with Rosetta response.
I wanted to go further and implement token_symbols, but noticed that something was off. Then found this thread. So leaving that for now... Some initial bits of token_symbols are in the branch
last-bits-search-tx-opt.This PR also adjusts some conditions in the query such that they fit the Rust implementation I think.