OpenAPI Playground #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
reviewed
Sep 27, 2024
| @@ -14,6 +14,7 @@ enum Command { | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() -> Result<()> { | |||
| dotenv::dotenv()?; | |||
There was a problem hiding this comment.
This causes ambiguous error when there's no .env file:
$ target/debug/mina_mesh serve
Error: path not found
Caused by:
path not found
piotr-iohk
reviewed
Sep 27, 2024
Comment on lines
+26
to
+29
| #[arg(env, long)] | ||
| playground: bool, | ||
| #[arg(env = "RUST_ENV", long)] | ||
| rust_env: String, |
There was a problem hiding this comment.
I think that having --rust-env as a required argument in the CLI is a bit unusual. I feel that just having --playground alone (although with a brief explanation) for switching on the playground should be enough and --rust-env could be removed entirely.
--playground
[env: PLAYGROUND=]
--rust-env <RUST_ENV>
[env: RUST_ENV=production]
piotr-iohk
reviewed
Sep 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interactive playground (a la Scalar) now visible on the root route via GET request.