Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

147 add labels to create project page and write them to system card on create project #237

Conversation

ChristopherSpelt
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt commented Sep 18, 2024

Description

add labels to create project page and write them to system card on create project

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilizes.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small comments

@ChristopherSpelt ChristopherSpelt force-pushed the 147-add-labels-to-create-project-page-and-write-them-to-system-card-on-create-project branch from 88990c1 to deae33b Compare September 20, 2024 07:17
ravimeijerrig
ravimeijerrig previously approved these changes Sep 24, 2024
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rows seem to have been duplicated.
For the rest LGTM :)

docs/projects/amt/reporting-standard/latest.md Outdated Show resolved Hide resolved
docs/projects/amt/reporting-standard/latest.md Outdated Show resolved Hide resolved
docs/projects/amt/reporting-standard/latest.md Outdated Show resolved Hide resolved
docs/projects/amt/reporting-standard/latest.md Outdated Show resolved Hide resolved
laurensWe
laurensWe previously approved these changes Sep 25, 2024
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the duplicate rows are removed I agree with this PR :)

@ChristopherSpelt ChristopherSpelt force-pushed the 147-add-labels-to-create-project-page-and-write-them-to-system-card-on-create-project branch from f567219 to 2c66b0c Compare September 25, 2024 08:53
ravimeijerrig
ravimeijerrig previously approved these changes Sep 25, 2024
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ChristopherSpelt ChristopherSpelt force-pushed the 147-add-labels-to-create-project-page-and-write-them-to-system-card-on-create-project branch from f7e6dcb to af3592d Compare September 25, 2024 13:34
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small adjustment

docs/projects/amt/reporting-standard/latest.md Outdated Show resolved Hide resolved
docs/projects/amt/reporting-standard/latest.md Outdated Show resolved Hide resolved
@ChristopherSpelt ChristopherSpelt force-pushed the 147-add-labels-to-create-project-page-and-write-them-to-system-card-on-create-project branch from dead59f to df8dafa Compare October 4, 2024 07:20
@ChristopherSpelt ChristopherSpelt force-pushed the 147-add-labels-to-create-project-page-and-write-them-to-system-card-on-create-project branch from df8dafa to 9a71a83 Compare October 4, 2024 07:21
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ChristopherSpelt ChristopherSpelt merged commit b2c6fc7 into main Oct 4, 2024
4 checks passed
@ChristopherSpelt ChristopherSpelt deleted the 147-add-labels-to-create-project-page-and-write-them-to-system-card-on-create-project branch October 4, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add labels to "Create Project page" and write them to system card on "create project"
5 participants