Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make readme good enough to merge #3

Open
wants to merge 1 commit into
base: readme
Choose a base branch
from

Conversation

tiesinto
Copy link

@tiesinto tiesinto commented Feb 14, 2025

Sorry for doing PRs inside of PRs but I added some of what we talked about in ynoproject/ynotranslations#181 since you said you'll be busy and I figured it would be easier to just get everything down and then worry about other issues later, since now you can just post this in the Discord and have people give feedback on stuff like the credits and also allow other people to potentionally improve this in the meantime. Sorry if it feels like this is rushing you though, feel free to ignore this until you have time to work on this if it's too much to ask for now but I just thought doing this might help.
Also of note, a different color picture header would probably work better but I don't want to make more PRs yet, when this is merged into the main repo I'll make a better logo and also record the video. I'll make a .gitignore for the README too so people won't download this file when they clone or download it as a zip.
Could you link me to the Discord messages you talked about earlier as a guide for translation? I'd like to do a translation for .flow and other fangames however I can't imagine how you would edit the picture files and such. Once I have all the references I need to understand translating I'll write a clear guide for it.

Sorry for doing PRs inside of PRs but I added some of what we talked about in ynoproject/pull/181 since you said you'll be busy and I figured it would be easier to just get everything down and then worry about other issues later, since now you can just post this in the Discord and have people give feedback on stuff like the credits and also allow other people to potentionally improve this in the meantime. Sorry if it feels like this is rushing you though, feel free to ignore this until you have time to work on this if it's too much to ask for now.
@Mimigris
Copy link
Owner

I think I should be able to work on the readme tomorrow, gonna review the changes you want to do in this pull request:

  • The logo directly pulled from the site is displayed on a dark background, but doesn't work here due to have a similar colour than the text, so it cannot just be used here
  • Not sure about the placement of the social networks (may be best lower than at the top, when reading a readme you may not necessarily want to directly ask support but rather read all first), and not sure either about Yume Wiki being directly grouped with social networks due to overhaul not being the same thing
    Will expand the translation instructions and OneShot section later, could be used as a basis 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants