Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time and BX filters #13

Open
wants to merge 16 commits into
base: bsInTimeRange_Run3
Choose a base branch
from
Open

Time and BX filters #13

wants to merge 16 commits into from

Conversation

lguzzi
Copy link
Member

@lguzzi lguzzi commented Feb 22, 2024 •
edited
Loading

Add EDFilters to filter on time range and bunch crossing. Useful for VdM tasks.
Adding also configurable pset for cmsRun and crab submitter.

quick test:

cmsRun EventSkimming_byTime_byBX.py inputFiles="file:alcareco_testfile.root" timerange="1687987757:1687988576" bunchcrossing=822 verbose=True maxEvents=100
python3 crab_skim_timerange_bx.py --input ../../VdMScans_2023/inputs/BI1.json --dataset /SpecialHLTPhysics0/Run2023C-PromptReco-v4/AOD --bunchcrossing 208 282 548 822 1197 1376 2716 2944 3123 --subfolder BeamSpot

@lguzzi lguzzi mentioned this pull request Feb 22, 2024
Closed
@lguzzi lguzzi changed the base branch from master to bsInTimeRange_Run3 February 22, 2024 14:38
@lguzzi lguzzi marked this pull request as draft February 22, 2024 14:39
francescobrivio
francescobrivio reviewed Mar 13, 2024
View reviewed changes
Copy link

@francescobrivio francescobrivio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part for the minor inline comments this looks good, maybe you can add in the PR description (or as a comment) an example command?

RecoVertex/BeamSpotProducer/plugins/BunchCrossingFilter.cc Outdated Show resolved Hide resolved
RecoVertex/BeamSpotProducer/plugins/TimeRangeFilter.cc Outdated Show resolved Hide resolved
RecoVertex/BeamSpotProducer/test/EventSkimming_byTime_byBX.py Outdated Show resolved Hide resolved
lguzzi and others added 4 commits March 13, 2024 16:33
@lguzzi lguzzi marked this pull request as ready for review March 14, 2024 13:51
@lguzzi
Update README.md
c7cb55c 
vdM instructions
@lguzzi
Update README.md
e313e89 
better text
@lguzzi
Update README.md
ee379f2 
more instructions, better instructions
@lguzzi
Update README.md
91c1efa 
plotting
@lguzzi
Update README.md
ad2f0fc 
typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescobrivio francescobrivio francescobrivio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lguzzi @francescobrivio