Skip to content

Commit

Permalink
Merge pull request #2 from Sam-Harper/GSIssueFixPATcustomize
Browse files Browse the repository at this point in the history
tighting the seed crystal matching
  • Loading branch information
rafaellopesdesa authored Jan 25, 2017
2 parents c77b076 + 2a2854d commit d60236a
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions RecoEcal/EgammaClusterProducers/src/EGRefinedSCFixer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
//
// for matching the new fixed superclusters vs old superclusters, the seed crystal may gain
// as the gain switched crystal will now have a larger energy
// but it should be within the 5x5 (really the 3x3 of the orginal SC)
// so we do a dIR = dIEta^2 + dIPhi^2 match of <=8 (ie be in the 5x5)
// but it really should be in the 3x3 of the orginal SC (the gain switch crysal has to be here to be redone)
// so we do a dIR = dIEta^2 + dIPhi^2 match of <=2 (ie be in the 3x3)
// but take the smallest dIR

// issues: sub cluster ordering may not be correct (its sorted by decreasing energy)
Expand Down Expand Up @@ -224,7 +224,8 @@ void EGRefinedSCFixer::produce(edm::Event & iEvent, const edm::EventSetup & iSet
// particleFlowEGamma can create superclusters directly out of PFClusters too
// -> there is not always a matching EB SC
if (orgEBSC.isNonnull()) {
auto fixedEBSC(GainSwitchTools::matchSCBySeedCrys(*orgEBSC, fixedEBSCs, 2, 2));
//changing the matching to be in 3x3 now (had issues with suprious matches)
auto fixedEBSC(GainSwitchTools::matchSCBySeedCrys(*orgEBSC, fixedEBSCs, 1, 1));

// here we may genuinely miss a mapping, if the seed position moves too much by re-reconstruction
// Sam: its very unlikely, if not impossible. To be replaced the gain switched crystal must be within +/-1 crystal a hybrid supercluster seed crystal because of ecalSelectedDigis. You could only get a shift larger than 1 if you had two supercluster seed crystals very close together and even then I'm not sure its possible.
Expand Down

0 comments on commit d60236a

Please sign in to comment.