Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new features #2

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Implement new features #2

wants to merge 35 commits into from

Conversation

seanhouli
Copy link

  • Suggestions are now clickable -- click on a suggestion to fill the input box with the suggested location
  • Suggestions are selectable with the up and down arrow keys when the mouse is outside of the suggestion list, and can also be chosen with the enter key
  • Addition of a callback prop which is called when a suggestion is clicked. The callback is supplied the location data as well as the click event
  • Addition of focus handling for the input
  • Addition of a selectedColor prop to customize the selection color of the suggestion list
  • Basic functionality tests have been added for the above features
  • The design looks cleaner

Sean Houlihan and others added 19 commits June 14, 2019 13:32
fixed styled components bug, added click callback prop as well as mak…
010e7de 
…ing suggestions clickable to update input text
@seanhouli
Merge pull request #1 from seanhouli/fix_styled_components_bug
02d6dde 
Fix styled components, make suggestions clickable
make suggestions disappear after clicking one
73d63ba
added ability to scroll and select suggestions with up/down arrow key…
07e4695 
…s and enter
prevent defaults on keys we're interested in
9016bda
get rid of logs
3b4bd04
refactored a bit, changed dark greys to light greys
388f697
add selectColor prop
0280174
suggestions disappear when input not in focus, callback now supplied …
c7b9df8 
…location object
add proptypes
b526295
update some deps, get testing to work
20b6ace
added tests, fixed some bugs
2915274
cleanup a bit
2586223
small bug fix
087514f
added readme, changed country prop to be optional
c63cad4
add gif to readme
7dd0c3e
change country to optional prop, add searchHint prop
252dcac
update readme
81b8dbd
refactor Suggestion
8738978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanhouli