Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slang] Fix virtual interface comparison #915

Conversation

likeamahoney
Copy link
Contributor

systemverilog LRM (for example IEEE 1800-2017 or IEEE 1800-2023) 25.9 clause says:

— Equality ( == ) and inequality ( != ) with the following:
• Another virtual interface of the same type
• An interface instance of the same type
• The special constant null

It follows that virtual interfaces can be compared with instances of the same type which is not supported by slang for now.

I fixed this at that PR.

Yan Churkin and others added 2 commits March 14, 2024 14:02
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (cad562f) to head (4fc070b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         190      190           
  Lines       47784    47799   +15     
=======================================
+ Hits        44799    44814   +15     
  Misses       2985     2985           
Files Coverage Δ
source/ast/expressions/OperatorExpressions.cpp 87.87% <100.00%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad562f...4fc070b. Read the comment docs.

@MikePopoloski
Copy link
Owner

Thanks for the PR!

@MikePopoloski MikePopoloski merged commit ab7dae5 into MikePopoloski:master Mar 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants