Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sveltekit minor version flexible #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arieroos
Copy link

This is a potential fix for issue #37

I haven't tested it, I'm not sure exactly how to do that. However I figured that opening a PR is a way to get the ball rolling on fixing the issue.

I made the sveltekit version flexible so that the project can use the same sveltekit version as the user, as long as it is >= 1.8.3 and < 2.0.0
That should fix issue #37 and any future security warnings that may arise from a fixed sveltekit version.

@wbudd
Copy link

wbudd commented Jun 4, 2023

Temporary workaround using this ^1.8.3 fix suggested above by @arieroos:

  1. npm uninstall sveltekit-adapter-aws (if currently installed)
  2. Add the following lines to your project's (root level) package.json:
"overrides": {
  "sveltekit-adapter-aws": {
    "@sveltejs/kit": "^1.8.3"
  }
}
  1. npm install -D sveltekit-adapter-aws

(Requires npm cli version 8.3.0 or newer.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants