Correctly handle multiple set-cookie headers #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how set-cookies headers with multiple values are returned. Previously, the code looks for Array types in the headers, but multiple values are actually stored as a comma delimited list. Following the adapter-netlify approach, the set-cookie-parser package is used to split the set-cookie header while all other headers are left unchanged.
|
I have added a version of the PR which includes some Vitest tests in #33, if that's useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how set-cookies headers with multiple values are returned. Previously, the code looks for Array types in the headers property, but multiple values are actually stored as a comma delimited list.
Following the adapter-netlify approach, the set-cookie-parser package is used here to split the set-cookie header while all other headers are left unchanged.