Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

provide a simple css selector to old message #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

am
Copy link
Member

@am am commented Mar 23, 2020

Currently on Week-1 > Exercise-6 > Point 4 we ask:

Make yesterday's message partially transparent to show it is old.

This is particularly confusing when learning the first CSS selectors, thus adding a specific class to the entire element will help to solve this.

See: https://migracodebarcelona.slack.com/archives/CMDSP2CQ2/p1584005696039700

Currently on Week1/exercise6>point 4 we ask:
> Make yesterday's message partially transparent to show it is old.

This is particularly confusing when learning the first CSS selectors, thus
adding a specific class to the entire element will help solving this.

See: https://migracodebarcelona.slack.com/archives/CMDSP2CQ2/p1584005696039700
@redspanner
Copy link

I agree, this should be a simple selector. We should also remove the class from the <time> tag so there is not confusion

@am
Copy link
Member Author

am commented Mar 24, 2020

I agree, this should be a simple selector. We should also remove the class from the <time> tag so there is not confusion

Thank you for the review @redspanner! I've updated the PR with your feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants