Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spotify authentication #2435

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

s-martin
Copy link
Collaborator

@s-martin s-martin commented Oct 7, 2024

This should fix #2429.

Everyone experiencing this issue is invited to test this fix.

@s-martin s-martin added spotify edition legacy_v2 Issues, discussions and PRs related to Version 2.x labels Oct 7, 2024
@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11654594800

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.51%

Totals Coverage Status
Change from base Build 11139253723: 0.0%
Covered Lines: 453
Relevant Lines: 577

💛 - Coveralls

@s-martin
Copy link
Collaborator Author

To be checked mopidy/mopidy-spotify#394 (comment)

@boboschkah
Copy link

Can someone please tell me what i have to do … i dont see the solution here!

@The-Judge
Copy link

The-Judge commented Oct 18, 2024

Can someone please tell me what i have to do … i dont see the solution here!

Hey @boboschkah , please find the solution here: mopidy/mopidy-spotify#405 (reply in thread)

@s-martin
Copy link
Collaborator Author

s-martin commented Nov 3, 2024

I can't test it, but from my point of view this could be merged.

@s-martin s-martin added this to the v2.8.0 milestone Nov 4, 2024
@pabera pabera self-requested a review November 4, 2024 07:20
@s-martin s-martin merged commit 501e561 into MiczFlor:develop Nov 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy_v2 Issues, discussions and PRs related to Version 2.x spotify edition
Projects
None yet
5 participants