Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to enable/disable Cover Art in Web App & load from filesystem #2352

Merged
merged 8 commits into from
Apr 21, 2024
Merged

feat: Allow to enable/disable Cover Art in Web App & load from filesystem #2352

merged 8 commits into from
Apr 21, 2024

Conversation

pabera
Copy link
Collaborator

@pabera pabera commented Apr 21, 2024 •
edited
Loading

  • feat: In certain situations it might be useful to disable cover art in the web app (especially when there is a lot music)
    • Allow Setting to be managed in Web App
  • feat: Try reading cover art from file system ([Cc]over.[jpg|png]) if it does not exist in audio file
    • Update Documentation
  • fix: fixes a bug where audio files pretended to have a cover art, but actually didn't.
  • Double check uncommon file type support (flac, m4a, ogg)

@pabera pabera self-assigned this Apr 21, 2024
@pabera pabera added enhancement future3 Relates to future3 development labels Apr 21, 2024
@pabera pabera added this to the v3.6 milestone Apr 21, 2024
@pabera pabera mentioned this pull request Apr 21, 2024
Open
@pabera pabera changed the title feat: Allow to enable/disable Cover Art in Web App feat: Allow to enable/disable Cover Art in Web App & load from filesystem Apr 21, 2024
@s-martin
Copy link
Collaborator

I like the possibility to get covers also from the file system, because that eases migration from V2.

@s-martin
Copy link
Collaborator

Do you also want to integrate the recently requested support of covers embedded in flac or m4a or should that be a different PR?

@pabera
Copy link
Collaborator Author

pabera commented Apr 21, 2024

Do you also want to integrate the recently requested support of covers embedded in flac or m4a or should that be a different PR?

Should already be covered

@pabera pabera merged commit aee32ff into MiczFlor:future3/develop Apr 21, 2024
24 checks passed
@pabera pabera deleted the webapp-settings-show-cover branch April 21, 2024 19:30
@s-martin s-martin linked an issue Apr 21, 2024 that may be closed by this pull request
🐛 | 3.6 crash when change to album view / Cover art caching with many songs #2329
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-martin s-martin s-martin approved these changes

@AlvinSchiller AlvinSchiller Awaiting requested review from AlvinSchiller

Assignees

@pabera pabera

Labels
enhancement future3 Relates to future3 development
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.

🐛 | 3.6 crash when change to album view / Cover art caching with many songs
2 participants
@pabera @s-martin