Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions update #2239

Merged
merged 8 commits into from
Feb 14, 2024
Merged

github actions update #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1794963
Bump actions/download-artifact from 3 to 4
AlvinSchiller Feb 4, 2024
f0313fd
Bump actions/upload-artifact from 3 to 4
AlvinSchiller Feb 4, 2024
d19d61d
Bump geekyeggo/delete-artifact from 2 to 4
AlvinSchiller Feb 4, 2024
1028402
add write permission for artifact deletion
AlvinSchiller Feb 4, 2024
a759d89
ignore fails for artifact deletion
AlvinSchiller Feb 5, 2024
121d70e
Revert "ignore fails for artifact deletion"
AlvinSchiller Feb 5, 2024
190ce9a
Revert "add write permission for artifact deletion"
AlvinSchiller Feb 5, 2024
1c534ec
remove cleanup stage for now
AlvinSchiller Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/bundle_webapp_and_release_v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
tar -czvf ${{ steps.vars.outputs.webapp_bundle_name }} build
- name: Artifact Upload
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.vars.outputs.webapp_bundle_name }}
path: ${{ steps.build-webapp.outputs.webapp-root-path }}/${{ steps.vars.outputs.webapp_bundle_name }}
Expand All @@ -119,7 +119,7 @@ jobs:

steps:
- name: Artifact Download
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ needs.build.outputs.webapp_bundle_name }}

Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/test_docker_debian_codename_sub_v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
BASE_TEST_IMAGE=${{ steps.vars.outputs.image_tag_name_local_base }}

- name: Artifact Upload Docker Image
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.vars.outputs.image_file_name }}
path: ${{ steps.vars.outputs.image_file_path }}
Expand All @@ -159,7 +159,7 @@ jobs:
uses: docker/[email protected]

- name: Artifact Download Docker Image
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ needs.build.outputs.image_file_name }}

Expand All @@ -177,15 +177,15 @@ jobs:
args: |
./${{ matrix.test_script }}

# cleanup after test execution
cleanup:
# run only if tests didn't fail: keep the artifact to make job reruns possible
if: ${{ !failure() }}
needs: [build, test]
runs-on: ${{ inputs.runs_on }}

steps:
- name: Artifact Delete Docker Image
uses: geekyeggo/delete-artifact@v2
with:
name: ${{ needs.build.outputs.image_file_name }}
## cleanup after test execution
#cleanup:
# # run only if tests didn't fail: keep the artifact to make job reruns possible
# if: ${{ !failure() }}
# needs: [build, test]
# runs-on: ${{ inputs.runs_on }}
#
# steps:
# - name: Artifact Delete Docker Image
# uses: geekyeggo/delete-artifact@v4
# with:
# name: ${{ needs.build.outputs.image_file_name }}
Loading