github actions update (#2239)

* Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/[email protected])

* Bump geekyeggo/delete-artifact from 2 to 4

* add write permission for artifact deletion

* ignore fails for artifact deletion

* Revert "ignore fails for artifact deletion"

This reverts commit a759d89.

* Revert "add write permission for artifact deletion"

This reverts commit 1028402.

* remove cleanup stage for now

.github/workflows/bundle_webapp_and_release_v3.yml

@@ -101,7 +101,7 @@ jobs:
           tar -czvf ${{ steps.vars.outputs.webapp_bundle_name }} build
 
       - name: Artifact Upload
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ steps.vars.outputs.webapp_bundle_name }}
           path: ${{ steps.build-webapp.outputs.webapp-root-path }}/${{ steps.vars.outputs.webapp_bundle_name }}
@@ -119,7 +119,7 @@ jobs:
 
     steps:
       - name: Artifact Download
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: ${{ needs.build.outputs.webapp_bundle_name }}
 

.github/workflows/test_docker_debian_codename_sub_v3.yml

@@ -134,7 +134,7 @@ jobs:
           BASE_TEST_IMAGE=${{ steps.vars.outputs.image_tag_name_local_base }}
 
     - name: Artifact Upload Docker Image
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ steps.vars.outputs.image_file_name }}
         path: ${{ steps.vars.outputs.image_file_path }}
@@ -159,7 +159,7 @@ jobs:
       uses: docker/[email protected]
 
     - name: Artifact Download Docker Image
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ${{ needs.build.outputs.image_file_name }}
 
@@ -177,15 +177,15 @@ jobs:
         args: |
           ./${{ matrix.test_script }}
 
-  # cleanup after test execution
-  cleanup:
-    # run only if tests didn't fail: keep the artifact to make job reruns possible
-    if: ${{ !failure() }}
-    needs: [build, test]
-    runs-on: ${{ inputs.runs_on }}
-
-    steps:
-        - name: Artifact Delete Docker Image
-          uses: geekyeggo/delete-artifact@v2
-          with:
-            name: ${{ needs.build.outputs.image_file_name }}
+  ## cleanup after test execution
+  #cleanup:
+  #  # run only if tests didn't fail: keep the artifact to make job reruns possible
+  #  if: ${{ !failure() }}
+  #  needs: [build, test]
+  #  runs-on: ${{ inputs.runs_on }}
+  #
+  #  steps:
+  #      - name: Artifact Delete Docker Image
+  #        uses: geekyeggo/delete-artifact@v4
+  #        with:
+  #          name: ${{ needs.build.outputs.image_file_name }}