Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Type Policy API #4494

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

File Type Policy API #4494

wants to merge 9 commits into from

Conversation

Master-Ukulele
Copy link

This is the review for new File Type Policy API

@david-risney david-risney added the API Proposal Review WebView2 API Proposal for review. label Apr 19, 2024
@david-risney david-risney self-requested a review April 19, 2024 21:56
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Show resolved Hide resolved
specs/FileTypePolicy.md Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
specs/FileTypePolicy.md Outdated Show resolved Hide resolved
The rewrite will address the following suggestions:
- use m_webview2_25 to match the patterns and simplify to remove the null check.
- case insensitive comparison
- avoid memory leak with wil::unique_cotaskmem_string
- include period for file extension
- replace .exe to .iso
- show the case of validating a trusted uri for .eml
- show the case of using deferral and customized UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Proposal Review WebView2 API Proposal for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants